Fix MakeFieldReadonly false positive for ref assignments #58459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Dec 22, 2021
ghost
modified the milestones:
| simpleAssignmentOperation.Value == operation && | ||
| simpleAssignmentOperation.IsRef) | ||
| { | ||
| return ValueUsageInfo.ReadableWritableReference; |
There was a problem hiding this comment.
if you have: readonly ref int x = ref y does this count as a read/write ref now? or just a read-ref? It should be the latter. Can you check, fix if necessary, and add test?
There was a problem hiding this comment.
➡️ Filed #58466 to resolve this comment
There was a problem hiding this comment.
Yep, agreed. This case should be readable reference, I'll make the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46785
Fixes #57983